Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix inline text #154

Merged
merged 3 commits into from
Oct 9, 2018
Merged

fix: fix inline text #154

merged 3 commits into from
Oct 9, 2018

Conversation

montezume
Copy link
Contributor

Summary

The isInline prop is currently broken for Text components.

Inline seems to be some sort of reserved word in stage 2 of postcss-preset-env. That's as far as my investigation got. If you switch to stage 3, then this doesn't happen. However, this doesn't happen in our webpack build, only in our rollup build.

when we build ui-kit with webpack (for storybook), it takes the following css

.inline {
  display: inline-block;
}

and it turns it into something like this

{
 inline: 'inline_mod_blah'
}

when we build ui-kit with webpack (for production), it takes the following css

.inline {
  display: inline-block;
}

and it turns it into something like this

{
 inline-left: 'inline_mod_blah',
 inline-right: 'inline_mod_blah',
}

It must be some sort of reserved word or something. I don't think it's worth further investigation.

Approach

Rename css class to text-inline.

@montezume montezume changed the title Ml fix inline text fix: fix inline text Oct 9, 2018
@montezume montezume self-assigned this Oct 9, 2018
@montezume montezume added the 🐛 Type: Bug Something isn't working label Oct 9, 2018
Copy link
Contributor

@dferber90 dferber90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙄 What a weird issue

@montezume
Copy link
Contributor Author

@dferber90 🤣

Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So odd.

@montezume montezume merged commit 22b863f into master Oct 9, 2018
@montezume montezume deleted the ml-fix-inline-text branch October 9, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants