refactor: replace invariant with tiny-invariant #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we are doing in the rollup config, the MC will need to add tiny-invariant as a dep, right? |
It has already. We use it there too and I replaced it there too. |
tdeekens
approved these changes
Oct 9, 2018
|
It's good that you pointed it out though, as we should mention it on the changelog as a breaking change. |
montezume
approved these changes
Oct 9, 2018
dferber90
force-pushed
the
df-replace-invariant
branch
from
314d410 to
0ac2b78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request replaces
invariantwithtiny-invariant. A simpler, more lightweight solution. Not the biggest of our problems but it was on my list. Essentiallytiny-invariantas the same API but does not allow placeholders in the string. Something we never used an if would use template literals for anyway.