Upgrade deps (drop reselect, drop MoneyInput workaround) #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezume
reviewed
Oct 5, 2018
| @@ -94,27 +91,27 @@ | |||
| "@storybook/addon-links": "4.0.0-alpha.20", | |||
| "@storybook/addon-options": "4.0.0-alpha.20", | |||
| "@storybook/react": "4.0.0-alpha.20", | |||
| "@svgr/rollup": "2.4.1", | |||
| "@svgr/webpack": "2.4.1", | |||
| "@svgr/rollup": "3.0.0", | |||
There was a problem hiding this comment.
would be cool to have a snapshot test that includes an icon, so that we could see easily if the svg output changed.
Workaround no longer required with [email protected]
montezume
approved these changes
Oct 5, 2018
This allows us to drop the 'reselect' dependency. Also removing some unused code along the way.
dferber90
force-pushed
the
df-upgrade-deps
branch
from
78ce7a5 to
f9c738c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reselectinCollapsiblePaneland drops thereselectdepMoneyInputFormik workaround. Closes Remove MoneyInput Formik workaround #109huskyand migrates itspackage.jsonconfigurationthemetypo of the Icons storyCollapsiblePanelfor a prop the component doesn't support anymore anyways (somebody can double-check this, I'm not entirely sure whether I interpreted the leftover code correctly)