fix(toggle-input): allow to pass value prop #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezume
approved these changes
Nov 19, 2019
|
I guess Percy didn't run because the PR wasn't open when the VRTs ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: in Formik v2 they changed a bit how checkbox and radio inputs deal with values
https://github.com/jaredpalmer/formik/releases/tag/v2.0.1
As we are upgrading our apps to formik v2, we started bumping into weird test failures and we narrowed the issue down to checkbox input types. It seems that if no
valueis provided, the default value ison, as described in the MDN .You can also see in the following codesandbox how the behavior differs:
https://codesandbox.io/s/formik-checkbox-value-i40kv
The fix
It appears that by passing both
valueandcheckedto the input, Formik handles the boolean value correctly.