feat(flat-button): add inverted tone
#1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezume
reviewed
Nov 12, 2019
| @@ -43,6 +43,14 @@ export const component = ({ themes }) => ( | |||
| icon={<InformationIcon />} | |||
| /> | |||
| </Spec> | |||
| <Spec label="inverted"> | |||
There was a problem hiding this comment.
Suggested change
| <Spec label="inverted"> | |
| <ThemeProvider theme={themes.darkTheme}> | |
| <Spec label="inverted"> | |
| <ThemeProvider theme={customProperties> | |
| <FlatButton | |
| tone="inverted" | |
| label="A label text" | |
| onClick={() => {}} | |
| icon={<InformationIcon />} | |
| /> | |
| <ThemeProvider> | |
| </Spec> | |
| </ThemeProvider> |
There was a problem hiding this comment.
You can also use listPropsOfNestedChild
montezume
approved these changes
Nov 12, 2019
montezume
reviewed
Nov 12, 2019
| @@ -44,10 +45,20 @@ export const component = ({ themes }) => ( | |||
| /> | |||
| </Spec> | |||
| <ThemeProvider theme={themes.darkTheme}> | |||
| <Spec label="secondary"> | |||
| <Spec label="inverted" listPropsOfNestedChild> | |||
| <ThemeProvider theme={vars}> | |||
There was a problem hiding this comment.
we do this to "reset" the theme back to the original.
|
stupid bot |
montezume
force-pushed
the
pa3-flat-button-inverted
branch
from
3cf413e to
6a55c14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invertedtone to<FlatButton />component. The use case for that is when<FlatButton />is used in the white-on-dark (given default ui-kit theme is used, of course) sections of application.font-color-for-text-when-invertedtoken