Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: primary button active and toggle state #1174

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

jonnybel
Copy link
Contributor

@jonnybel jonnybel commented Nov 12, 2019

Summary

Fixes the active and toggled state of PrimaryButton, because of some leftover deprecated design tokens we forgot to update on version 10.0.0 😅

Before: (the button remains the same when clicked or toggled)
After:
image

@jonnybel jonnybel added 🐛 Type: Bug Something isn't working Semver: FIX labels Nov 12, 2019
@jonnybel jonnybel requested a review from montezume November 12, 2019 11:01
@jonnybel jonnybel self-assigned this Nov 12, 2019
@jonnybel
Copy link
Contributor Author

Re-ran the CI workflow because Percy got clogged or something 🚽

@jonnybel
Copy link
Contributor Author

jonnybel commented Nov 12, 2019

I've checked the Percy diffs and they're the expected changes. I'm approving and 🚢

@kodiakhq kodiakhq bot merged commit 71fc660 into master Nov 12, 2019
@kodiakhq kodiakhq bot deleted the ja-fix-primary-button-active branch November 12, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants