feat(checkbox-input): support isReadOnly prop #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezume
commented
Nov 4, 2019
| const { onChange } = props; | ||
|
|
||
| const handleChange = React.useCallback( | ||
| event => !props.isReadOnly && onChange && onChange(event), |
There was a problem hiding this comment.
Why use JS? Why isn't setting readOnly on the input enough?
https://stackoverflow.com/questions/155291/can-html-checkboxes-be-set-to-readonly
There was a problem hiding this comment.
Thanks for sharing. I often wanted to ask UX "what's the different line in communication towards the user between readonly and disabled? When use which?"
montezume
commented
Nov 4, 2019
| baseStyles, | ||
| css` | ||
| svg [id$='borderAndContent'] > [id$='content'] { | ||
| fill: ${overwrittenVars[designTokens.fontColorForInputWhenReadonly]}; |
There was a problem hiding this comment.
same look as for RadioInputs when readOnly
tdeekens
approved these changes
Nov 4, 2019
| const { onChange } = props; | ||
|
|
||
| const handleChange = React.useCallback( | ||
| event => !props.isReadOnly && onChange && onChange(event), |
There was a problem hiding this comment.
Thanks for sharing. I often wanted to ask UX "what's the different line in communication towards the user between readonly and disabled? When use which?"
jonnybel
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses one of the cases here