fix(buttons): fix onClick bug #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezume
commented
Oct 21, 2019
| @@ -73,7 +73,7 @@ describe('rendering', () => { | |||
| describe('when using "linkTo"', () => { | |||
| it('should navigate to link when clicked', async () => { | |||
| const { getByLabelText, history } = render( | |||
| <SecondaryButton {...props} linkTo="/foo/bar" /> | |||
| <SecondaryButton {...props} onClick={null} linkTo="/foo/bar" /> | |||
There was a problem hiding this comment.
this test failed in same way as the current issues in MC-FE before making the code change 👍
tdeekens
approved these changes
Oct 21, 2019
pa3
approved these changes
Oct 21, 2019
jonnybel
reviewed
Oct 21, 2019
|
I think the failing tests were due to onClick being undefined and not being disabled. |
|
Hmm yeah, I didn't understand it correctly before 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the button is NOT disabled, then we should check that
onClickexists before calling it 🤦♂This usually affects link buttons.