fix(accessible-button): use not-allowed cursor on disabled #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezume
commented
Oct 21, 2019
| expect(button).toHaveAttribute('aria-disabled', 'true'); | ||
|
|
||
| button.click(); | ||
| expect(onClick).not.toHaveBeenCalled(); |
There was a problem hiding this comment.
before we couldn't test this as pointer-events: none doesn't stop you from calling onClick manually 😆
There was a problem hiding this comment.
although TBH testing disabled is kind of dumb
jonnybel
approved these changes
Oct 21, 2019
There was a problem hiding this comment.
Using pointer-events: none for disabled buttons/inputs isn't a good practice, I like it much better with this approach 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors our Buttons to display
cursor: not-allowedwhen disabled.Fixes #1113