Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flat-button): fully support theming #1056

Merged
merged 1 commit into from
Sep 12, 2019
Merged

fix(flat-button): fully support theming #1056

merged 1 commit into from
Sep 12, 2019

Conversation

montezume
Copy link
Contributor

Summary

We were supporting theming, but not for the "neutral" state.

@montezume montezume self-assigned this Sep 11, 2019
@montezume montezume requested a review from jonnybel September 11, 2019 13:31
@montezume montezume added the 🐛 Type: Bug Something isn't working label Sep 11, 2019
tdeekens
tdeekens approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Curious: what do we need it for?

@montezume
Copy link
Contributor Author

@tdeekens not entirely sure to be honest. @pa3 is having some issue with theming on the FlatButton, and when I looked at the code I saw this...

@montezume montezume merged commit 8dabdc7 into master Sep 12, 2019
@montezume montezume deleted the ml-flat-button-fix branch September 12, 2019 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdeekens tdeekens tdeekens approved these changes

@jonnybel jonnybel jonnybel approved these changes

Assignees

@montezume montezume

Labels
🐛 Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@montezume @tdeekens @jonnybel