fix(collapsible-motion): do not set to null on rerender #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezume
commented
Sep 3, 2019
| @@ -65,16 +66,14 @@ const useToggleAnimation = (isOpen, toggle, minHeight) => { | |||
| ? { height: 'auto' } | |||
| : { height: getMinHeight(minHeight), overflow: 'hidden' }; | |||
|
|
|||
| let animation = null; | |||
|
|
|||
| // if state has changed | |||
| if (typeof prevIsOpen !== 'undefined' && prevIsOpen !== isOpen) { | |||
There was a problem hiding this comment.
before if the component re-rendered without a toggle, animation was reset to null. Now the animation stays. The animation should be null for the FIRST toggle, and then after that it should remain without being reset to null
tdeekens
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for the
CollapsibleMotioncomponent. Currently if the component is rerendered without the isOpen prop changing, the animation is lost. Leading to bugs