Skip to content

Commit 7d35c2e

Browse files
authored
fix(error-message): support data-attributes (#424)
1 parent 677dc77 commit 7d35c2e

File tree

2 files changed

+18
-4
lines changed

2 files changed

+18
-4
lines changed

src/components/messages/error-message/error-message.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
import React from 'react';
22
import PropTypes from 'prop-types';
33
import Text from '../../typography/text';
4+
import filterDataAttributes from '../../../utils/filter-data-attributes';
45

56
const ErrorMessage = props => (
6-
<Text.Detail tone="negative">{props.children}</Text.Detail>
7+
<Text.Detail tone="negative" {...filterDataAttributes(props)}>
8+
{props.children}
9+
</Text.Detail>
710
);
811
ErrorMessage.displayName = 'ErrorMessage';
912
ErrorMessage.propTypes = {

src/components/messages/error-message/error-message.spec.js

+14-3
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,19 @@ import React from 'react';
22
import { render } from '../../../test-utils';
33
import ErrorMessage from './error-message';
44

5-
it('should render children', () => {
6-
const { container } = render(<ErrorMessage>Some error message</ErrorMessage>);
5+
describe('ErrorMessage', () => {
6+
it('should render children', () => {
7+
const { container } = render(
8+
<ErrorMessage>Some error message</ErrorMessage>
9+
);
710

8-
expect(container).toHaveTextContent('Some error message');
11+
expect(container).toHaveTextContent('Some error message');
12+
});
13+
14+
it('should forward data-attributes', () => {
15+
const { container } = render(
16+
<ErrorMessage data-foo="bar">Some error message</ErrorMessage>
17+
);
18+
expect(container.querySelector('[data-foo="bar"]')).toBeInTheDocument();
19+
});
920
});

0 commit comments

Comments
 (0)