fix(buttons): make onClick not required if as is passed (#1189)

* fix(buttons): make onClick not required if as is passed

* chore: pr comments

Author: montezume

src/components/buttons/flat-button/flat-button.js

@@ -2,6 +2,7 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import { css } from '@emotion/core';
 import omit from 'lodash/omit';
+import requiredIf from 'react-required-if';
 import vars from '../../../../materials/custom-properties';
 import filterInvalidAttributes from '../../../utils/filter-invalid-attributes';
 import Text from '../../typography/text';
@@ -116,7 +117,7 @@ FlatButton.propTypes = {
   tone: PropTypes.oneOf(['primary', 'secondary', 'inverted']),
   type: PropTypes.oneOf(['submit', 'reset', 'button']),
   label: PropTypes.string.isRequired,
-  onClick: PropTypes.func.isRequired,
+  onClick: requiredIf(PropTypes.func, props => !props.as),
   icon: PropTypes.element,
   iconPosition: PropTypes.oneOf(['left', 'right']),
   isDisabled: PropTypes.bool,

src/components/buttons/primary-button/primary-button.js

@@ -2,6 +2,7 @@ import PropTypes from 'prop-types';
 import React from 'react';
 import isNil from 'lodash/isNil';
 import omit from 'lodash/omit';
+import requiredIf from 'react-required-if';
 import { css } from '@emotion/core';
 import vars from '../../../../materials/custom-properties';
 import filterInvalidAttributes from '../../../utils/filter-invalid-attributes';
@@ -73,7 +74,7 @@ PrimaryButton.propTypes = {
     return PropTypes.bool(props, propName, componentName, ...rest);
   },
   isDisabled: PropTypes.bool,
-  onClick: PropTypes.func.isRequired,
+  onClick: requiredIf(PropTypes.func, props => !props.as),
   size: PropTypes.oneOf(['big', 'small']),
   tone: PropTypes.oneOf(['urgent', 'primary']),
 };

src/components/buttons/secondary-icon-button/secondary-icon-button.js

@@ -1,6 +1,7 @@
 import React from 'react';
 import PropTypes from 'prop-types';
 import omit from 'lodash/omit';
+import requiredIf from 'react-required-if';
 import filterInvalidAttributes from '../../../utils/filter-invalid-attributes';
 import AccessibleButton from '../accessible-button';
 import { getBaseStyles } from './secondary-icon-button.styles';
@@ -38,7 +39,7 @@ SecondaryIconButton.propTypes = {
   icon: PropTypes.element.isRequired,
   color: PropTypes.oneOf(['solid', 'primary']),
   label: PropTypes.string.isRequired,
-  onClick: PropTypes.func.isRequired,
+  onClick: requiredIf(PropTypes.func, props => !props.as),
   isDisabled: PropTypes.bool,
 };