Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate medium font weight going to bold font weight #696

Closed
kkoreilly opened this issue Dec 25, 2023 · 2 comments
Closed

Investigate medium font weight going to bold font weight #696

kkoreilly opened this issue Dec 25, 2023 · 2 comments
Assignees
@kkoreilly
Labels
bug Something isn't working correctly needs discussion Need to discuss what to do
Milestone
v0.3

Comments

@kkoreilly
Copy link
Member

This seems to be due to backup logic in girl that is causing some fonts to be rendered as bold instead of medium.
@kkoreilly kkoreilly added the bug Something isn't working correctly label Dec 25, 2023
@kkoreilly kkoreilly added this to the v2 milestone Dec 25, 2023
@kkoreilly kkoreilly self-assigned this Dec 25, 2023
@kkoreilly
Copy link
Member Author

This is related to #515, #568, and goki/freetype#2: we need to resolve how we handle different fonts, font weights, and fallback fonts in general.

@kkoreilly kkoreilly added the needs discussion Need to discuss what to do label Feb 7, 2024
@kkoreilly
Copy link
Member Author

This is not an issue, and I misunderstood the situation when I initially filed it. The current behavior is correct; if you specify something to be medium of a font you don't have medium for, it is perfectly fine for it to fall back on bold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkoreilly kkoreilly

Labels
bug Something isn't working correctly needs discussion Need to discuss what to do
Projects
None yet
Milestone
v0.3
Development

No branches or pull requests
1 participant
@kkoreilly