Skip to content

Commit 72e71ed

Browse files
committed
Merge branch 'main' into eap
2 parents 0a4f879 + 7bb9a67 commit 72e71ed

File tree

9 files changed

+21
-10
lines changed

9 files changed

+21
-10
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535

3636
# Check out current repository
3737
- name: Fetch Sources
38-
uses: actions/checkout@v3.1.0
38+
uses: actions/checkout@v3.3.0
3939

4040
# Validate wrapper
4141
- name: Gradle Wrapper Validation
@@ -134,7 +134,7 @@ jobs:
134134

135135
# Check out current repository
136136
- name: Fetch Sources
137-
uses: actions/checkout@v3.1.0
137+
uses: actions/checkout@v3.3.0
138138

139139
# Remove old release drafts by using the curl request for the available releases with draft flag
140140
- name: Remove Old Release Drafts

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515

1616
# Check out current repository
1717
- name: Fetch Sources
18-
uses: actions/checkout@v3.1.0
18+
uses: actions/checkout@v3.3.0
1919
with:
2020
ref: ${{ github.event.release.tag_name }}
2121

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44

55
## Unreleased
66

7+
### Fixed
8+
- support for `Remote Development` in the Jetbrains IDE's
9+
710
## 2.1.4-eap.0 - 2022-12-23
811
Bug fixes and enhancements included in `2.1.4` release:
912

README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Follow](https://img.shields.io/twitter/follow/CoderHQ?label=%40CoderHQ&style=soc
2727

2828
## Getting Started
2929

30-
![Install this plugin from the JetBrains Marketplace](https://plugins.jetbrains.com/plugin/19620-coder-gateway)
30+
[Install this plugin from the JetBrains Marketplace](https://plugins.jetbrains.com/plugin/19620-coder/)
3131

3232
## Manually Building
3333

@@ -142,6 +142,8 @@ An artifact file is also built with the plugin attached. Every new Build overrid
142142
When you edit the draft and use the <kbd>Publish release</kbd> button, GitHub will tag the repository with the given version and add a new entry to the Releases tab.
143143
Next, it will notify users who are *watching* the repository, triggering the final [Release](.github/workflows/release.yml) workflow.
144144

145+
> **IMPORTANT:** `pluginVersion` from `gradle.properties` needs to be manually increased after a release.
146+
145147
### Plugin signing
146148

147149
Plugin Signing is a mechanism introduced in the 2021.2 release cycle to increase security in [JetBrains Marketplace](https://plugins.jetbrains.com).

build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ dependencies {
3333
exclude("org.slf4j")
3434
}
3535

36-
testImplementation(platform("org.apache.groovy:groovy-bom:4.0.6"))
36+
testImplementation(platform("org.apache.groovy:groovy-bom:4.0.7"))
3737
testImplementation("org.apache.groovy:groovy")
3838
testImplementation(platform("org.spockframework:spock-bom:2.3-groovy-4.0"))
3939
testImplementation("org.spockframework:spock-core")

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
pluginGroup=com.coder.gateway
44
pluginName=coder-gateway
55
# SemVer format -> https://semver.org
6-
pluginVersion=2.1.4-eap.0
6+
pluginVersion=2.1.5-eap.0
77
# See https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
88
# for insight into build numbers and IntelliJ Platform versions.
99
pluginSinceBuild=223.7571.70

src/main/kotlin/com/coder/gateway/views/steps/CoderLocateRemoteProjectStepView.kt

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ import com.jetbrains.gateway.ssh.IdeWithStatus
4040
import com.jetbrains.gateway.ssh.IntelliJPlatformProduct
4141
import kotlinx.coroutines.CoroutineScope
4242
import kotlinx.coroutines.Dispatchers
43+
import kotlinx.coroutines.async
4344
import kotlinx.coroutines.cancel
4445
import kotlinx.coroutines.launch
4546
import kotlinx.coroutines.withContext
@@ -146,16 +147,18 @@ class CoderLocateRemoteProjectStepView(private val disableNextAction: () -> Unit
146147
}
147148
} else {
148149
logger.info("Resolved OS and Arch for ${selectedWorkspace.name} is: $workspaceOS")
149-
val installedIdes = withContext(Dispatchers.IO) {
150+
val installedIdesJob = async(Dispatchers.IO) {
150151
hostAccessor.getInstalledIDEs().map { ide -> IdeWithStatus(ide.product, ide.buildNumber, IdeStatus.ALREADY_INSTALLED, null, ide.pathToIde, ide.presentableVersion, ide.remoteDevType) }
151152
}
152-
val idesWithStatus = withContext(Dispatchers.IO) {
153+
val idesWithStatusJob = async(Dispatchers.IO) {
153154
IntelliJPlatformProduct.values()
154155
.filter { it.showInGateway }
155156
.flatMap { CachingProductsJsonWrapper.getInstance().getAvailableIdes(it, workspaceOS) }
156157
.map { ide -> IdeWithStatus(ide.product, ide.buildNumber, IdeStatus.DOWNLOAD, ide.download, null, ide.presentableVersion, ide.remoteDevType) }
157158
}
158159

160+
val installedIdes = installedIdesJob.await()
161+
val idesWithStatus = idesWithStatusJob.await()
159162
if (installedIdes.isEmpty()) {
160163
logger.info("No IDE is installed in workspace ${selectedWorkspace.name}")
161164
} else {

src/main/resources/META-INF/plugin.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,10 @@
99
<depends>com.intellij.modules.platform</depends>
1010

1111
<!-- TODO: enable this when https://youtrack.jetbrains.com/issue/GTW-1528/Plugin-depends-on-unknown-plugin-comjetbrainsgateway is fixed-->
12-
<!-- depends>com.jetbrains.gateway</depends>-->
12+
<!-- <depends>com.jetbrains.gateway</depends>-->
13+
14+
<!-- we trick Gateway into no longer rasing the unknown module error by marking the dependency optional-->
15+
<depends optional="true">com.jetbrains.gateway</depends>
1316

1417
<extensions defaultExtensionNs="com.intellij">
1518
<applicationService serviceImplementation="com.coder.gateway.sdk.CoderRestClientService"></applicationService>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
minCompatibleCoderVersion=0.12.9
2-
maxCompatibleCoderVersion=0.13.6
2+
maxCompatibleCoderVersion=1.0.0

0 commit comments

Comments
 (0)