Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e testing gauntlet + scaffold #4320

Closed
3 tasks
jsjoeio opened this issue Oct 7, 2021 · 2 comments
Closed
3 tasks

Add e2e testing gauntlet + scaffold #4320

jsjoeio opened this issue Oct 7, 2021 · 2 comments
Labels
testing Anything related to testing
Milestone

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Oct 7, 2021

@bryphe-coder and I were talking about improving our e2e test structure both in open-source and the product. One idea is to have a Testing Gauntlet where we run e2e tests through a series of trials (say repeat each test 30 times) before it gets added to the codebase. Then have a nightly job that runs the unstable/flakey tests.

How it Works

Here's what I'm thinking:

  1. Developer writes new e2e test and adds to test/e2e/unstable
  2. Developer opens and merges PR
  3. Each night, CI runs ci/dev/test-gauntlet.sh which does the following:
  4. Runs tests in test/e2e/unstable and captures success results.
  5. If new test passes gauntlet (i.e. 30 successful runs), then CI commits new test, opens PR and assigns to Testing Team
  6. Testing Team reviews PRs from CI and merges in

Implementation

  • figuring out directory scaffolding unstable or nightly in test/e2e
  • write test-gauntlet.sh script
  • add CI job which runs on a schedule and opens PRs into main
@jsjoeio jsjoeio added the testing Anything related to testing label Oct 7, 2021
@jsjoeio jsjoeio added this to the On Deck milestone Oct 7, 2021
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Oct 7, 2021

i feel like sometimes even when it shouldn’t matter, the order in which I run tests affects their flakiness. so when you’re designing the gauntlet you might go for 30 runs of the test suite rather than do test 1 30x, do test 2 30x, you know?

good feedback from @presleyp - the order of the tests shouldn't matter

@stale
Copy link

stale bot commented Apr 5, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

@stale stale bot added the stale label Apr 5, 2022
@stale stale bot closed this as completed Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to testing
Projects
None yet
Development

No branches or pull requests

1 participant