[print] Fix map entries being spliced in non-map collections #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-yakushev
force-pushed
the
print-map-entry
branch
3 times, most recently
from
2577b38 to
4dd15c3
Compare
bbatsov
reviewed
Aug 28, 2024
src/orchard/print.clj
Outdated
| (defn- print-coll [^TruncatingStringWriter w, ^Iterable x, ^String sep | ||
| ^String prefix, ^String suffix] | ||
| ^String prefix, ^String suffix, map?] |
There was a problem hiding this comment.
Not a big fan of this boolean param, but I can live with it. Perhaps we can at least make it somewhat optional, so we don't have to pass false around.
There was a problem hiding this comment.
Updated it to be optional. Does it look that much better for you? It's a private function anyway.
There was a problem hiding this comment.
Not much better, but a bit better - in general I'm not a big fan of boolean params, as I always have to consult the method signature to remember/understand what some boolean flag is supposed to do. But I agree it's not a big deal in our case, given it's a private API.
alexander-yakushev
force-pushed
the
print-map-entry
branch
from
4dd15c3 to
3dc37c2
Compare
bbatsov
approved these changes
Aug 28, 2024
|
Thanks for the quick fix! Note there's a typo in the changelog, 290 -> 292 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #291.