-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] Don't crash if none of the parsers can be initialized #288
Conversation
fb643a2
to
08bf5f5
Compare
The culprit was not the Another sidenote is the usage of "JDK9" in the names. Obviously, we won't change the existing ones for no reason, but I suggest we use JDK11 as the LTS version that we actually support. |
I'm fine with updating the references to JDK 9 - they are there just because it introduced the module system (that probably no one is using still) and all the complexity that came with it. I think the LTS concept was added shortly afterward, but we forgot to update the references accordingly. |
src/orchard/java/jdk11.clj
Outdated
@@ -0,0 +1,7 @@ | |||
(ns orchard.java.jdk11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt there will be anything else here that's not related to modules, so this can also be something like orchard.java.modules
. I'm not very fond of linking ns names to specific versions of something. But I don't feel strongly about this.
dc50180
to
e9ab24b
Compare
Replaced all mentions of JDK9. |
e9ab24b
to
2f2f206
Compare
This might be a good time for a new Orchard release. |
Which version of cider-nrepl includes this fix, please? |
The latest one certainly does. |
Context here: https://clojurians.slack.com/archives/C17JYSA3H/p1724172844138059
On the JRE, loading CIDER (and hence Orchard) produces an exception like this: