[inspect] Don't crash when inspecting internal classes #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alexander-yakushev
commented
Aug 1, 2024
•
alexander-yakushev
commented
- You've added tests to cover your change(s)
- You've updated the changelog
alexander-yakushev
force-pushed
the
internal-inspect
branch
4 times, most recently
from
390739a to
b8b720b
Compare
bbatsov
reviewed
Aug 1, 2024
| (as-> member-string s | ||
| (string/replace s #"[\w\.]+\.(\w+\()" "$1") ;; remove class from method name | ||
| (string/replace s #"[\w\.]+\.(\w+)$" "$1") ;; remove class from field name | ||
| (if-let [canonical (.getCanonicalName class)] |
There was a problem hiding this comment.
Maybe add a comment here explaining when we won't have the canonical name?
There was a problem hiding this comment.
Left a comment, the list is in the javadoc for .getCanonicalName.
|
The PR looks good to me. |
alexander-yakushev
force-pushed
the
internal-inspect
branch
from
b8b720b to
c5644e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.