[inspector] Display count in the header for objects with known size #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-yakushev
force-pushed
the
known-size
branch
2 times, most recently
from
7e7cb8f to
9b9c8c8
Compare
alexander-yakushev
force-pushed
the
known-size
branch
from
9b9c8c8 to
606995f
Compare
alexander-yakushev
force-pushed
the
known-size
branch
from
606995f to
25fed39
Compare
|
The code looks good to me, although it seems there's a small spacing mistake that results in failing CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to how it was already done for arrays, Counted objects now also show their size upfront.