Catch NoClassDefFoundError #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exception can be thrown on a case indifferent filesystem, eg. on OS X. One way this happens is if there is a java class with a camel cased name that otherwise matches the name of a clojure namespace. For some reason, when this exception was thrown, the classes in the class cache were also getting initialised.
|
Looking reasonable to me - thanks! |
bbatsov
reviewed
Jan 15, 2024
src/orchard/meta.clj
Outdated
| (catch java.lang.NoClassDefFoundError _ | ||
| ;; this can happen if there is a java class with a camel cased name | ||
| ;; that otherwise matches the name of a clojure namespace, on a case | ||
| ;; indifferent filesystem, eg. on OS X. |
There was a problem hiding this comment.
I believe it's named macOS these days. :-)
|
Same, just needs a changelog entry. |
|
Thanks! Would you need a release asap? Otherwise I'd bundle it with other stuff next weekend |
|
No rush, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exception can be thrown on a case indifferent filesystem, eg. on
macOS.
One way this happens is if there is a java class with a camel cased name
that otherwise matches the name of a clojure namespace.
For some reason, when this exception was thrown, the classes in the
class cache were also getting initialised.