Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust client SDK: Remove use of ?connection_id query param to subscribe HTTP route #2280

Open
gefjon opened this issue Feb 19, 2025 · 1 comment

Comments

@gefjon
Copy link
Contributor

gefjon commented Feb 19, 2025

Currently, the SDK generates its ConnectionId locally, and passes it to the subscribe HTTP route. This is wrong; the server should (and would, given the opportunity) generate a unique ConnectionId for the connection and return it to the client. Rework the Rust client SDK to that effect.

DoD: When running the Rust client SDK tests, the host logs do not contain any lines like:

2025-02-19T15:53:04.862398Z DEBUG /home/phoebe/clockworklabs/SpacetimeDB/crates/client-api/src/routes/subscribe.rs:74: The connection_id query parameter to the subscribe HTTP endpoint is internal and will be removed in a future version of SpacetimeDB.    
@gefjon
Copy link
Contributor Author

gefjon commented Feb 19, 2025

I think this is higher priority than the C# and TypeScript tickets since the Rust client SDK re-uses a single ConnectionId throughout the whole process, whereas the other two SDKs (I think) generate a fresh one for each new connection. So the Rust SDK is misbehaving in a user-facing way, whereas the other two are just using an internal API that we'd like to remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant