Skip to content

Commit 0113525

Browse files
[no-story] allow empty blocks (#17)
## Summary Our [style guide](https://circlepay.atlassian.net/wiki/spaces/ENGINEERIN/pages/386957608/Circle+Java+Style+Guide#Empty-blocks%3A-may-be-concise) allows for empty blocks. We update our Checkstyle to allow empty blocks, too. ## Detail ### Prior to this change This was illegal: ```java class Clazz {} ``` ### With this change This is legal: ```java class Clazz {} ``` This is legal, too: ```java class Clazz { } ``` This is still illegal: ```java class Class { private String field; } ``` ## Testing This change passes on entity-service & transaction-core. ## Documentation None. --- **Requested Reviewers:** @asharp-circle @creilly12 @istvancircle @rschmitz-circle
2 parents 994157c + aa00cac commit 0113525

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

checkstyle-circle.xml

+1-7
Original file line numberDiff line numberDiff line change
@@ -73,16 +73,10 @@
7373
value="LITERAL_TRY, LITERAL_CATCH, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE,
7474
LITERAL_DO"/>
7575
</module>
76-
<module name="RightCurly">
77-
<property name="id" value="RightCurlyAlone"/>
78-
<property name="option" value="alone"/>
79-
<property name="tokens"
80-
value="CLASS_DEF, LITERAL_FOR, LITERAL_WHILE, STATIC_INIT, INSTANCE_INIT"/>
81-
</module>
8276
<module name="RightCurly">
8377
<property name="id" value="RightCurlyAloneOrSingleLine"/>
8478
<property name="option" value="alone_or_singleline"/>
85-
<property name="tokens" value="CTOR_DEF, METHOD_DEF"/>
79+
<property name="tokens" value="CLASS_DEF, CTOR_DEF, INSTANCE_INIT, LITERAL_FOR, LITERAL_WHILE, METHOD_DEF, STATIC_INIT"/>
8680
</module>
8781
<module name="WhitespaceAround">
8882
<property name="allowEmptyConstructors" value="true"/>

0 commit comments

Comments
 (0)