Skip to content

Commit e0933ab

Browse files
Revert "[lldb][target] Add progress report for wait-attaching to process" (llvm#144810)
This is breaking TestCreateAfterAttach.py on Ubuntu: ``` ====================================================================== FAIL: test_create_after_attach_dwo (TestCreateAfterAttach.CreateAfterAttachTestCase.test_create_after_attach_dwo) Test thread creation after process attach. ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1804, in test_method return attrvalue(self) ^^^^^^^^^^^^^^^ File "/home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/llvm-project/lldb/packages/Python/lldbsuite/test/decorators.py", line 149, in wrapper return func(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^ File "/home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/llvm-project/lldb/test/API/functionalities/thread/create_after_attach/TestCreateAfterAttach.py", line 36, in test_create_after_attach self.runCmd("process attach -p " + str(pid)) File "/home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1005, in runCmd self.assertTrue(self.res.Succeeded(), msg + output) AssertionError: False is not true : Command 'process attach -p 1474309' did not return successfully Error output: error: attach failed: lost connection ``` on the buildbots for lldb-remote-linux-ubuntu, lldb-arm-ubuntu, lldb-aarch64-ubuntu, lldb-arm-ubuntu.
1 parent 00ae89a commit e0933ab

File tree

2 files changed

+0
-32
lines changed

2 files changed

+0
-32
lines changed

lldb/source/Target/Target.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3546,7 +3546,6 @@ llvm::Expected<TraceSP> Target::GetTraceOrCreate() {
35463546
}
35473547

35483548
Status Target::Attach(ProcessAttachInfo &attach_info, Stream *stream) {
3549-
Progress attach_progress("Waiting to attach to process");
35503549
m_stats.SetLaunchOrAttachTime();
35513550
auto state = eStateInvalid;
35523551
auto process_sp = GetProcessSP();

lldb/test/API/functionalities/progress_reporting/TestProgressReporting.py

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
Test that we are able to broadcast and receive progress events from lldb
33
"""
44
import lldb
5-
import threading
65

76
import lldbsuite.test.lldbutil as lldbutil
87

@@ -17,36 +16,6 @@ def setUp(self):
1716
self.broadcaster, lldb.SBDebugger.eBroadcastBitProgress
1817
)
1918

20-
def test_wait_attach_progress_reporting(self):
21-
"""Test that progress reports for wait attaching work as intended."""
22-
self.build()
23-
target = self.dbg.CreateTarget(None)
24-
25-
# Wait attach to a process, then check to see that a progress report was created
26-
# and that its message is correct for waiting to attach to a process.
27-
class AttachThread(threading.Thread):
28-
def __init__(self, target):
29-
threading.Thread.__init__(self)
30-
self.target = target
31-
32-
def run(self):
33-
self.target.AttachToProcessWithName(
34-
lldb.SBListener(), "a.out", True, lldb.SBError()
35-
)
36-
37-
thread = AttachThread(target)
38-
thread.start()
39-
40-
event = lldbutil.fetch_next_event(self, self.listener, self.broadcaster)
41-
progress_data = lldb.SBDebugger.GetProgressDataFromEvent(event)
42-
message = progress_data.GetValueForKey("message").GetStringValue(100)
43-
self.assertEqual(message, "Waiting to attach to process")
44-
45-
# Interrupt the process attach to keep the test from stalling.
46-
target.process.SendAsyncInterrupt()
47-
48-
thread.join()
49-
5019
def test_dwarf_symbol_loading_progress_report(self):
5120
"""Test that we are able to fetch dwarf symbol loading progress events"""
5221
self.build()

0 commit comments

Comments
 (0)