Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using string Literal for DatasetArtifact.type #7482

Open
Bento007 opened this issue Mar 7, 2025 · 0 comments
Open

fix: using string Literal for DatasetArtifact.type #7482

Bento007 opened this issue Mar 7, 2025 · 0 comments
Labels
dp Data Platform workstream

Comments

@Bento007
Copy link
Contributor

Bento007 commented Mar 7, 2025

we can do this in a follow up PR, but it might make sense to use string literals that way you still have some type enforcement but passing strings makes it more flexible for db / API layer.

https://mypy.readthedocs.io/en/stable/literal_types.html

Originally posted by @joyceyan in #7479 (comment)

@brianraymor brianraymor added the dp Data Platform workstream label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dp Data Platform workstream
Projects
None yet
Development

No branches or pull requests

2 participants