Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs for data loaders #1291

Closed
ivirshup opened this issue Oct 1, 2024 · 1 comment · Fixed by #1292
Closed

Fix docs for data loaders #1291

ivirshup opened this issue Oct 1, 2024 · 1 comment · Fixed by #1292
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@ivirshup
Copy link
Collaborator

ivirshup commented Oct 1, 2024

In #1289 (comment) @yanwu2014 noted that the docs still say we are returning the soma_join_ids per batch in all cases, even though we removed that behavior. We can see that here:

image

We should fix that.
@ivirshup ivirshup added bug Something isn't working documentation Improvements or additions to documentation labels Oct 1, 2024
@ivirshup ivirshup mentioned this issue Oct 1, 2024
Merged
@yanwu2014
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
2 participants
@yanwu2014 @ivirshup