Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shwap/bitswap: Memory leak #4151

Open
Wondertan opened this issue Mar 6, 2025 · 0 comments
Open

shwap/bitswap: Memory leak #4151

Wondertan opened this issue Mar 6, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@Wondertan
Copy link
Member

Image

This branch contains changes that minimized the affect for the leak, but didn't completely solved.

The main hunch is related to high peer churn, as with stable connections this is not reproducible. Also, this is demonstrated by ipfs/boxo@4becbe1, which was the commit that fixed alleviated the most pressure. This commit avoids automatic WANT_HAVE broadcast to every connected peer, relying on internal rebroadcast inside session instead.

@Wondertan Wondertan added the bug Something isn't working label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant