Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask peers for receive rate #1523

Closed
evan-forbes opened this issue Oct 31, 2024 · 1 comment
Closed

Ask peers for receive rate #1523

evan-forbes opened this issue Oct 31, 2024 · 1 comment
Labels
WS: Big Blonks 🔭 Improving consensus critical gossiping protocols

Comments

@evan-forbes
Copy link
Member

Currently, peers use configured send and receive rates. If the send rate of either peer is higher than the receive rate of the other, and this much bandwidth gets hit, it will disconnect from that peer.

This is problematic because we can't actively change this value safely without every node in the network changing at the same time.

Instead of coordinating around new values, peers should simply ask the peers what their receive rates are and adjust accordingly. If the peer doesn't respond, then they can be presumed to using the default of roughly 5MiB/s.

To close this issue, we need to create a backwards compatible mechanism for asking for the peer's receive limit during the handshake, then potentially adjusting the send rate.

@evan-forbes evan-forbes added the WS: Big Blonks 🔭 Improving consensus critical gossiping protocols label Oct 31, 2024
@evan-forbes evan-forbes changed the title Ask peers for Ask peers for receive rate Oct 31, 2024
@evan-forbes
Copy link
Member Author

actually, upon further review with @rach-id, it doesn't look like we're disconnecting from peers that exceed the receive rate

If so this isn't needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WS: Big Blonks 🔭 Improving consensus critical gossiping protocols
Projects
None yet
Development

No branches or pull requests

1 participant