fix: tx search only returning one tx (#1533)

Author: ninabarbakadze

state/txindex/kv/kv.go

@@ -382,7 +382,11 @@ func (txi *TxIndex) setTmpHashes(tmpHeights map[string][]byte, it dbm.Iterator,
 		eventSeq := extractEventSeqFromKey(it.Key())
 		tmpHeights[string(it.Value())+eventSeq] = it.Value()
 	} else {
-		tmpHeights[string(it.Value())] = it.Value()
+		// Copy it.Value() to ensure tmpHeights stores independent values, as iterators reuse
+		// the same memory for it.Value(), causing overwrites on each iteration.
+		valueCopy := make([]byte, len(it.Value()))
+		copy(valueCopy, it.Value())
+		tmpHeights[string(it.Value())] = valueCopy
 	}
 }
 

state/txindex/kv/kv_test.go

@@ -692,8 +692,18 @@ func TestTxSearchMultipleTxs(t *testing.T) {
 
 	results, err := indexer.Search(ctx, query.MustParse("account.number >= 1"))
 	assert.NoError(t, err)
-
 	require.Len(t, results, 3)
+
+	// since two txs were added at height 1 and 2, we should have two unique transactions
+	// for both heights
+	results, err = indexer.Search(ctx, query.MustParse("tx.height=1"))
+	assert.NoError(t, err)
+	require.Len(t, results, 2)
+
+	results, err = indexer.Search(ctx, query.MustParse("tx.height=2"))
+	assert.NoError(t, err)
+	require.Len(t, results, 2)
+
 }
 
 func txResultWithEvents(events []abci.Event) *abci.TxResult {