Skip to content

Commit 890a59b

Browse files
rootulprach-id
andauthoredDec 10, 2024··
chore: deprecate timeout_commit and timeout_propose config (#1551)
Closes #1550 ## Testing In celestia-app I replaced celestia-core with this repo. Then created a new config file and observed: ```toml # How long we wait for a proposal block before prevoting nil # Deprecated: timeout_commit is overridden by the state machine in app version >= 3. # Therefore, the value set in this config will be ignored. timeout_propose = "3.5s" # How long we wait after committing a block, before starting on the new # height (this gives us a chance to receive some more precommits, even # though we already have +2/3). # Deprecated: timeout_commit is overridden by the state machine in app version >= 3. # Therefore, the value set in this config will be ignored. timeout_commit = "4.2s" ``` --------- Co-authored-by: CHAMI Rachid <[email protected]>
1 parent 9a514ad commit 890a59b

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed
 

‎config/toml.go

+4
Original file line numberDiff line numberDiff line change
@@ -480,6 +480,8 @@ only_internal_wal = "{{ .Consensus.OnlyInternalWal }}"
480480
wal_file = "{{ js .Consensus.WalPath }}"
481481
482482
# How long we wait for a proposal block before prevoting nil
483+
# Deprecated: timeout_commit is overridden by the state machine in app version >= 3.
484+
# Therefore, the value set in this config will be ignored.
483485
timeout_propose = "{{ .Consensus.TimeoutPropose }}"
484486
# How much timeout_propose increases with each round
485487
timeout_propose_delta = "{{ .Consensus.TimeoutProposeDelta }}"
@@ -494,6 +496,8 @@ timeout_precommit_delta = "{{ .Consensus.TimeoutPrecommitDelta }}"
494496
# How long we wait after committing a block, before starting on the new
495497
# height (this gives us a chance to receive some more precommits, even
496498
# though we already have +2/3).
499+
# Deprecated: timeout_commit is overridden by the state machine in app version >= 3.
500+
# Therefore, the value set in this config will be ignored.
497501
timeout_commit = "{{ .Consensus.TimeoutCommit }}"
498502
499503
# How many blocks to look back to check existence of the node's consensus votes before joining consensus

0 commit comments

Comments
 (0)
Please sign in to comment.