track if we see missing transcations which are invalid

Author: cmwaters

mempool/cat/block_builder.go

@@ -158,6 +158,19 @@ func (bf *blockFetcher) TryAddMissingTx(key types.TxKey, tx []byte) {
 	}
 }
 
+// IsMissingTx checks if a given transaction is missing from any of the block requests.
+func (bf *blockFetcher) IsMissingTx(key types.TxKey) bool {
+	bf.mtx.Lock()
+	defer bf.mtx.Unlock()
+	for _, request := range bf.requests {
+		_, ok := request.missingKeys[key.String()]
+		if ok {
+			return true
+		}
+	}
+	return false
+}
+
 // PruneOldRequests removes any requests that are older than the given height.
 func (bf *blockFetcher) pruneOldRequests(height int64) {
 	for blockID, request := range bf.requests {

mempool/cat/reactor.go

@@ -263,6 +263,10 @@ func (memR *Reactor) ReceiveEnvelope(e p2p.Envelope) {
 			}
 			_, err = memR.mempool.TryAddNewTx(ntx, key, txInfo)
 			if err != nil && err != ErrTxInMempool && err != ErrTxRecentlyCommitted {
+				if memR.blockFetcher.IsMissingTx(key) {
+					memR.Logger.Error("tx in block is not valid by mempool")
+				}
+
 				memR.Logger.Info("Could not add tx from peer", "peerID", peerID, "txKey", key, "err", err)
 				return
 			}