Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce complexity and document retrieval of malleated transacions #942

Closed
Tracked by #514
evan-forbes opened this issue Aug 1, 2022 · 3 comments
Closed
Tracked by #514
Labels
documentation Improvements or additions to documentation

Comments

@evan-forbes
Copy link
Member

Currently, there are three different hashes for a malleated tx:

  • The original hash of the tx that the user submitted
  • The hash of the malleated tx itself (a MsgPayForData)
  • The hash of the wrapped malleated tx that is in the block

This is very confusing and has not been documented well enough, particularly what hash is used when. We need to formalize and document when each hash is used, and see if we can refactor tx indexing to simplify this further.

@rootulp rootulp transferred this issue from celestiaorg/celestia-core Nov 1, 2022
@rootulp rootulp added the documentation Improvements or additions to documentation label Nov 1, 2022
@evan-forbes
Copy link
Member Author

evan-forbes commented Nov 15, 2022

blocked by implementing #835 and #894

@rootulp
Copy link
Collaborator

rootulp commented Nov 15, 2022

Potentially obsolete if we can remove transaction hash tracking from celestia-core

@evan-forbes
Copy link
Member Author

we've since removed malleation as mentioned by Rootul, so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants