Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the tx inclusion proving code to follow the non-interactive defaults #703

Closed
Tracked by #514
evan-forbes opened this issue Sep 13, 2022 · 5 comments
Closed
Tracked by #514
Assignees

Comments

@evan-forbes
Copy link
Member

in #702 we're moving the tx inclusion code to the app, from which we can query it from core as part of #698. We will also have to update that code so that it follows the non-interactive defaults.

@evan-forbes
Copy link
Member Author

related to #956

@rach-id
Copy link
Member

rach-id commented Nov 21, 2022

Any more details on this? Which parts of the tx inclusion doesn't support NID?
I think they're independent of that, since for the transaction, which don't follow NID, we go over the transactions to get the index. Then, from the transaction, we get the start index of the message.
Let me know what I am missing please

@evan-forbes
Copy link
Member Author

there could be a message in the same row as the txs, which depends on NIDs, and is needed to create proofs to the txs.

ideally we don't regenerate the entire square each time, but if that makes it easier then I say we do it and optimize later.

one easy optimization is to encode the entire block data into shares, but then only erasure the relevant rows when creating proofs

@rach-id
Copy link
Member

rach-id commented Nov 21, 2022

ideally we don't regenerate the entire square each time, but if that makes it easier then I say we do it and optimize later.

In a tx inclusion proof, we receive the block data already generated from core, why regenerate?

@rootulp
Copy link
Collaborator

rootulp commented Jan 19, 2023

Closing in favor of #1243

@rootulp rootulp closed this as not planned Won't fix, can't repro, duplicate, stale Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants