Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a wrapped tx decoder in decode sub command #485

Closed
Tracked by #514
evan-forbes opened this issue Jun 15, 2022 · 3 comments
Closed
Tracked by #514

Use a wrapped tx decoder in decode sub command #485

evan-forbes opened this issue Jun 15, 2022 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@evan-forbes
Copy link
Member

We use a special malleated tx decoder for malleated txs. This decoder is not currently used in the decode sub command. We can do that by using the malleated tx decoder by default #430 (strongly preferred approach) or by creating a new decode command that uses the special decoder.
@evan-forbes evan-forbes added bug Something isn't working good first issue Good for newcomers labels Jun 15, 2022
@adlerjohn adlerjohn moved this to TODO in Celestia Node Jun 15, 2022
@evan-forbes evan-forbes mentioned this issue Jul 1, 2022
Closed
41 tasks
@evan-forbes
Copy link
Member Author

evan-forbes commented Aug 26, 2022 •
edited
Loading

we might just want to close this considering we don't always want to add the overhead of the malleated txs decoder mistaken for #430

Repository owner moved this from TODO to Done in Celestia Node Oct 3, 2022
@evan-forbes
Copy link
Member Author

whoops, closed on accident, as I meant to close #430

@evan-forbes evan-forbes reopened this Oct 3, 2022
Repository owner moved this from Done to In Progress in Celestia Node Oct 3, 2022
@evan-forbes evan-forbes changed the title Use a malleated tx decoder in decode sub command Use a wrapped tx decoder in decode sub command Jan 12, 2023
@evan-forbes evan-forbes mentioned this issue Jan 20, 2023
Closed
4 tasks
@evan-forbes evan-forbes mentioned this issue Apr 26, 2023
Closed
@evan-forbes
Copy link
Member Author

closing in favor of #1665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@evan-forbes