Skip to content

Commit 32d7c9f

Browse files
SteelPhaseuvfive
authored andcommitted
Fix missing newline in IncreaseLevel error messages (uber-go#828)
1 parent a040928 commit 32d7c9f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

increase_level_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ func TestIncreaseLevelTryDecrease(t *testing.T) {
5858
newLoggedEntry(ErrorLevel, "increase level error log"),
5959
}, logs.AllUntimed(), "unexpected logs")
6060
assert.Equal(t,
61-
`failed to IncreaseLevel: invalid increase level, as level "info" is allowed by increased level, but not by existing core`,
61+
"failed to IncreaseLevel: invalid increase level, as level \"info\" is allowed by increased level, but not by existing core\n",
6262
errorOut.String(),
6363
"unexpected error output",
6464
)

options.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ func IncreaseLevel(lvl zapcore.LevelEnabler) Option {
125125
return optionFunc(func(log *Logger) {
126126
core, err := zapcore.NewIncreaseLevelCore(log.core, lvl)
127127
if err != nil {
128-
fmt.Fprintf(log.errorOutput, "failed to IncreaseLevel: %v", err)
128+
fmt.Fprintf(log.errorOutput, "failed to IncreaseLevel: %v\n", err)
129129
} else {
130130
log.core = core
131131
}

0 commit comments

Comments
 (0)