Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give Humbug integrations ability to present users with reports when asking for consent #24

Open
zomglings opened this issue Mar 18, 2021 · 0 comments

Comments

@zomglings
Copy link
Member

Consent is checked on every report publication anyway, so it makes sense for consent.ConsentMechanism functions to take an optional Report argument. This can be used to present users with the contents of the report for approval, so they can see exactly what they are consenting to.

Future flows along these lines: users are presented with a raw report and they can modify it prior to giving consent.

Something to think about, the only change required here would be to change the definition of ConsentMechanism from Callable[[], bool] to Callable[[Optional[Report]], bool].

As it stands now, this would introduce a circular dependency between humbug.consent and humbug.report, so we would have to move Report into another file (e.g. data.py).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant