Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requestResource in canonical string generation should be urlencoded #8

Closed
wyozi opened this issue Mar 9, 2023 · 1 comment
Closed

requestResource in canonical string generation should be urlencoded #8

wyozi opened this issue Mar 9, 2023 · 1 comment

Comments

@wyozi
Copy link
Contributor

wyozi commented Mar 9, 2023

Trying to retrieve a resource from s3 e.g. /my/folder/työnantaja.pdf fails, because the ö character in canonical string generation is not urlencoded properly.

Passing it through encodeURI (i.e. canonical.push(encodeURI(requestResource));) makes the above request work.

Don't ask why paths like this are stored in our s3 bucket 😬
@bradenmacdonald
Copy link
Owner

Fixed in v0.5. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bradenmacdonald @wyozi