Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add home and playground links to sidebar navigation #3654

Merged
merged 5 commits into from
Jul 9, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Jul 9, 2019

Describe the PR

adds homepage and playground links to sidebar navigation

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • [] It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #3654 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3654   +/-   ##
=======================================
  Coverage   99.26%   99.26%           
=======================================
  Files         224      224           
  Lines        4346     4346           
  Branches     1229     1229           
=======================================
  Hits         4314     4314           
  Misses         26       26           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7cb071...4e0814a. Read the comment docs.

@tmorehouse tmorehouse changed the title docs: add homepage link to sidebar navigation docs: add homepage and playground links to sidebar navigation Jul 9, 2019
@tmorehouse tmorehouse requested a review from jacobmllr95 July 9, 2019 19:05
@jacobmllr95 jacobmllr95 changed the title docs: add homepage and playground links to sidebar navigation feat(docs): add home and playground links to sidebar navigation Jul 9, 2019
@jacobmllr95 jacobmllr95 merged commit e5eb9fc into dev Jul 9, 2019
@jacobmllr95 jacobmllr95 deleted the tmorehouse/docs-sidebar branch July 9, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants