Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect return code when you try to lint non-existent files #48

Open
Tattoo opened this issue Mar 16, 2018 · 0 comments
Open

Incorrect return code when you try to lint non-existent files #48

Tattoo opened this issue Mar 16, 2018 · 0 comments

Comments

@Tattoo
Copy link

Tattoo commented Mar 16, 2018

If one tries to lint non-existent files, rflint returns with the code 0.

The problematic line is shown here; I believe either ERROR or "other" count should be increased so later on when reporting rflint would also fail.

Return code of zero is problematic especially in the context of CI, where automation relies on error codes to know should we continue or not. In our case for example, we use linting as a quality gate for later phases. Since we have a lot of test cases, we try to figure out in CI specifically what tests should go through the pipeline. If we have a bug in this, rflint does not stop the pipeline which becomes a problem in later phases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant