Skip to content

Commit 8f83ca7

Browse files
committed
Remove "Assignees" and "Authors" filters from issues page
Remove the "Assignees" and "Authors" filters from the issues page, including the view code that fetches their data. Especially the "Authors" filter was problematic, as it contained all 25k users who ever wrote a bug report, including HTML to download and render their avatar. This was basically a DOS on the browser. See go-gitea#22549 for the upstream bug report about this.
1 parent 1de906e commit 8f83ca7

File tree

2 files changed

+19
-12
lines changed

2 files changed

+19
-12
lines changed

routers/web/repo/issue.go

+15-12
Original file line numberDiff line numberDiff line change
@@ -297,18 +297,21 @@ func issues(ctx *context.Context, milestoneID, projectID int64, isPullOption uti
297297
ctx.Data["CommitLastStatus"] = lastStatus
298298
ctx.Data["CommitStatuses"] = commitStatuses
299299

300-
// Get assignees.
301-
ctx.Data["Assignees"], err = repo_model.GetRepoAssignees(ctx, repo)
302-
if err != nil {
303-
ctx.ServerError("GetAssignees", err)
304-
return
305-
}
306-
307-
ctx.Data["Posters"], err = repo_model.GetIssuePosters(ctx, repo, isPullOption.IsTrue())
308-
if err != nil {
309-
ctx.ServerError("GetIssuePosters", err)
310-
return
311-
}
300+
// Disabled by Sybren (2023-01-24) to speed up rendering of the issues page.
301+
// See https://github.com/go-gitea/gitea/issues/22586 for more info.
302+
//
303+
// // Get assignees.
304+
// ctx.Data["Assignees"], err = repo_model.GetRepoAssignees(ctx, repo)
305+
// if err != nil {
306+
// ctx.ServerError("GetAssignees", err)
307+
// return
308+
// }
309+
310+
// ctx.Data["Posters"], err = repo_model.GetIssuePosters(ctx, repo, isPullOption.IsTrue())
311+
// if err != nil {
312+
// ctx.ServerError("GetIssuePosters", err)
313+
// return
314+
// }
312315

313316
handleTeamMentions(ctx)
314317
if ctx.Written() {

templates/repo/issue/list.tmpl

+4
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,9 @@
9292
{{end}}
9393
</div>
9494
</div>
95+
{{- /*
96+
Disabled by Sybren (2023-01-24) to speed up rendering of the issues page.
97+
See https://github.com/go-gitea/gitea/issues/22586 for more info.
9598

9699
<!-- Author -->
97100
<div class="ui {{if not .Posters}}disabled{{end}} dropdown jump item">
@@ -132,6 +135,7 @@
132135
{{end}}
133136
</div>
134137
</div>
138+
*/ -}}
135139

136140
{{if .IsSigned}}
137141
<!-- Type -->

0 commit comments

Comments
 (0)