rename param, create a helper, document in README

Author: John T Skarbek

bitnami/redis/README.md

@@ -86,6 +86,8 @@ The command removes all the Kubernetes components associated with the chart and
 | `diagnosticMode.enabled` | Enable diagnostic mode (all probes will be disabled and the command will be overridden) | `false`         |
 | `diagnosticMode.command` | Command to override all containers in the deployment                                    | `["sleep"]`     |
 | `diagnosticMode.args`    | Args to override all containers in the deployment                                       | `["infinity"]`  |
+| `useExternalDNS.enabled` | Enable various syntax that would enable external-dns to work.  Note this requires a working installation of `external-dns` to be usable. | `false` |
+| `useExternalDNS.suffix`  | The DNS suffix utilized when `external-dns` is enabled.  Note that we prepend the suffix with the full name of the install.              | `""`    |
 
 
 ### Redis™ Image parameters

bitnami/redis/templates/_helpers.tpl

@@ -274,3 +274,8 @@ redis: tls.enabled
     enable auto-generated certificates.
 {{- end -}}
 {{- end -}}
+
+{{/* Define the suffix utilized for external-dns */}}
+{{- define "redis.externalDNS.suffix" -}}
+{{ printf "%s.%s" (include "common.names.fullname" .) .Values.useExternalDNS.suffix }}
+{{- end -}}

bitnami/redis/templates/headless-svc.yaml

@@ -11,8 +11,8 @@ metadata:
   {{- if .Values.commonAnnotations }}
   {{- include "common.tplvalues.render" ( dict "value" .Values.commonAnnotations "context" $ ) | nindent 4 }}
   {{- end }}
-  {{- if .Values.externalDNS.enabled }}
-    external-dns.alpha.kubernetes.io/hostname: {{ printf "%s.%s" (include "common.names.fullname" .) .Values.externalDNS.suffix }}
+  {{- if .Values.useExternalDNS.enabled }}
+    external-dns.alpha.kubernetes.io/hostname: {{ include "redis.externalDNS.suffix" . }}
   {{- end }}
 spec:
   type: ClusterIP

bitnami/redis/templates/scripts-configmap.yaml

@@ -43,8 +43,8 @@ data:
     get_full_hostname() {
         hostname="$1"
 
-        {{- if .Values.externalDNS.enabled }}
-        echo "${hostname}.{{- printf "%s.%s" (include "common.names.fullname" .) .Values.externalDNS.suffix }}"
+        {{- if .Values.useExternalDNS.enabled }}
+        echo "${hostname}.{{- include "redis.externalDNS.suffix" . }}"
         {{- else if eq .Values.sentinel.service.type "NodePort" }}
         echo "${hostname}.{{- .Release.Namespace }}"
         {{- else }}
@@ -250,8 +250,8 @@ data:
     get_full_hostname() {
         hostname="$1"
 
-        {{- if .Values.externalDNS.enabled }}
-        echo "${hostname}.{{- printf "%s.%s" (include "common.names.fullname" .) .Values.externalDNS.suffix }}"
+        {{- if .Values.useExternalDNS.enabled }}
+        echo "${hostname}.{{- include "redis.externalDNS.suffix" . }}"
         {{- else if eq .Values.sentinel.service.type "NodePort" }}
         echo "${hostname}.{{- .Release.Namespace }}"
         {{- else }}
@@ -400,8 +400,8 @@ data:
     get_full_hostname() {
         hostname="$1"
 
-        {{- if .Values.externalDNS.enabled }}
-        echo "${hostname}.{{- printf "%s.%s" (include "common.names.fullname" .) .Values.externalDNS.suffix }}"
+        {{- if .Values.useExternalDNS.enabled }}
+        echo "${hostname}.{{- include "redis.externalDNS.suffix" . }}"
         {{- else if eq .Values.sentinel.service.type "NodePort" }}
         echo "${hostname}.{{- .Release.Namespace }}"
         {{- else }}
@@ -547,8 +547,8 @@ data:
     get_full_hostname() {
         hostname="$1"
 
-        {{- if .Values.externalDNS.enabled }}
-        echo "${hostname}.{{- printf "%s.%s" (include "common.names.fullname" .) .Values.externalDNS.suffix }}"
+        {{- if .Values.useExternalDNS.enabled }}
+        echo "${hostname}.{{- include "redis.externalDNS.suffix" . }}"
         {{- else if eq .Values.sentinel.service.type "NodePort" }}
         echo "${hostname}.{{- .Release.Namespace }}"
         {{- else }}

bitnami/redis/values.yaml

@@ -23,9 +23,9 @@ global:
 ## @section Common parameters
 ##
 
-## @param externalDNS Boolean to indicate the desire to utilize `external-dns`
+## @param useExternalDNS Boolean to indicate the desire to utilize `external-dns`
 ##
-externalDNS:
+useExternalDNS:
   enabled: false
   # suffix: ""