[FIX] ScoringSheetViewer computing target class values from base values #7025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7025 +/- ##
==========================================
+ Coverage 88.36% 88.62% +0.25%
==========================================
Files 332 332
Lines 73345 73381 +36
==========================================
+ Hits 64813 65034 +221
+ Misses 8532 8347 -185 |
… sort attributes by importance
ZanMervic
force-pushed
the
bugfix/6996/use-base-values-on-target-switch
branch
from
f79ef51 to
67f6d2d
Compare
janezd
reviewed
Mar 6, 2025
| @@ -510,15 +515,32 @@ def _extract_data_from_model(self, classifier): | |||
| all_risks = 1 / (1 + np.exp(-all_scaled_scores)) | |||
|
|
|||
| self.attributes = attributes | |||
| self._base_coefficients = coefficients | |||
| self._base_all_scores = all_scores.tolist() | |||
| self._base_all_risks = (all_risks * 100).tolist() | |||
| self.coefficients = coefficients | |||
There was a problem hiding this comment.
Are these three lines still necessary? These attributes are set in self._adjust_for_target_class, which is called a few lines later.
| Sorts the attributes in descending order of importance (absolute coefficient value) | ||
| by combining the attributes and coefficients into tuples and sorting them. | ||
| """ | ||
| combined = list( |
There was a problem hiding this comment.
No need to call list here. You can pass a zip object to sorted; sorted will work on any iterable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #6996
Description of changes
Includes