Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add S-Nominated-To-Close to the contributor's guide #1938

Open
alice-i-cecile opened this issue Mar 4, 2025 · 0 comments · May be fixed by #1941
Open

Add S-Nominated-To-Close to the contributor's guide #1938

alice-i-cecile opened this issue Mar 4, 2025 · 0 comments · May be fixed by #1941
Labels
A-Contributing-Guide C-Content S-Ready-For-Implementation The core questions are answered: just add code X-Blessed Has a large architectural impact or tradeoffs, but the design has been endorsed by decision makers

Comments

@alice-i-cecile
Copy link
Member

The core idea here is that PR backlogs are unwieldy, and community members / triage team members should feel empowered to close out / say no to things that are stale, obsolete or a questionable idea. Historically, while they've had the power to simply close PRs / issues, the triage team has been reluctant to do so.

Main points to hit are:

  1. Leave reasoning about why you think it should be closed.
  2. If you disagree (as a reviewer / author), please feel free to argue your case.

This label has already been added to the main Bevy repo :)
@alice-i-cecile alice-i-cecile added A-Contributing-Guide C-Content S-Ready-For-Implementation The core questions are answered: just add code X-Blessed Has a large architectural impact or tradeoffs, but the design has been endorsed by decision makers labels Mar 4, 2025
@krunchington krunchington linked a pull request Mar 7, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Contributing-Guide C-Content S-Ready-For-Implementation The core questions are answered: just add code X-Blessed Has a large architectural impact or tradeoffs, but the design has been endorsed by decision makers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add S-Nominated-To-Close to triage docs krunchington/bevy-website
1 participant
@alice-i-cecile