Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaks for me using Ember 2.10.0 #135

Closed
gobijan opened this issue Dec 6, 2016 · 5 comments
Closed

Breaks for me using Ember 2.10.0 #135

gobijan opened this issue Dec 6, 2016 · 5 comments

Comments

@gobijan
Copy link

gobijan commented Dec 6, 2016

Hi I upgraded to ember 2.10.0 and the uploader supporting multiple files broke for me.
Is Ember 2.10.0 supported?
@digitaltoad
Copy link
Member

Multi file is still supported. Any examples?

@joneath
Copy link
Contributor

joneath commented Dec 7, 2016 •
edited
Loading

Looks like the latest version changed how isArray works with FileLists which is breaking multi-file upload support (falling to the else case starting at line 91 of uploaders/base.js). emberjs/ember.js#12708

@joneath
Copy link
Contributor

joneath commented Dec 7, 2016

I've submitted a pull request here: #136

@gobijan
Copy link
Author

gobijan commented Dec 8, 2016

To speed things up a bit (I need this in production):
#138

@digitaltoad
Copy link
Member

Fixed with 62959a6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@digitaltoad @gobijan @joneath