Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails with ember-concurrency#277 and Ember canary #6

Closed
gitKrystan opened this issue Feb 13, 2019 · 2 comments
Closed

Fails with ember-concurrency#277 and Ember canary #6

gitKrystan opened this issue Feb 13, 2019 · 2 comments

Comments

@gitKrystan
Copy link

gitKrystan commented Feb 13, 2019

I'm trying to get our tests passing on Ember canary and ran into the issue you described in machty/ember-concurrency#279 (thanks for tracking that down, by the way).

I pointed our ember-try 'canary' scenario at machty/ember-concurrency#277, but now I'm running into this assertion from ember-concurrency-test-waiter:

assert("withTestWaiter() will only work with ember-concurrency >=0.7.19 -- please upgrade", taskProperty.taskFn);

@bendemboski
Copy link
Owner

Right, thanks for the report @gitKrystan -- that PR is definitely going to break ember-concurrency-test-waiter (not just the compatibility check, but the whole mechanism to install a test waiter will no longer work!). I'll work on a solution, and hopefully get some help!

@bendemboski
Copy link
Owner

Fixed via machty/ember-concurrency#277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants