Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ballerine-io/ballerine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: @ballerine/[email protected]
Choose a base ref
...
head repository: ballerine-io/ballerine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dev
Choose a head ref

Commits on Sep 2, 2024

  1. Copy the full SHA
    61919ac View commit details
  2. Added local only secrets (#2663)

    * feat(*): added local only secrets
    
    * refactor(workflows-service): renamed secrets variable
    Omri-Levy authored Sep 2, 2024
    Copy the full SHA
    b3aaf6d View commit details
  3. Batch report upload (#2662)

    * feat: batch report upload
    
    * feat: pr comments fixes
    
    * feat: pr comments fixes
    
    * feat: pr comment fix
    
    * feat: conflict fix
    tomer-shvadron authored Sep 2, 2024
    Copy the full SHA
    32a769b View commit details
  4. Copy the full SHA
    c9b57df View commit details
  5. Copy the full SHA
    d37f5fe View commit details
  6. Copy the full SHA
    040e685 View commit details
  7. Illiar/fix/mastercard plugin data structure (#2668)

    * fix: updated schema & changed address source
    
    * fix: fixed data structure and method bug
    
    ---------
    
    Co-authored-by: Illia Rudniev <cheskmr@gmail.com>
    alonp99 and chesterkmr authored Sep 2, 2024
    Copy the full SHA
    e154494 View commit details
  8. Copy the full SHA
    1bfc683 View commit details
  9. version bump

    alonp99 committed Sep 2, 2024
    Copy the full SHA
    9285966 View commit details
  10. version bump

    alonp99 committed Sep 2, 2024
    Copy the full SHA
    9eafcf6 View commit details
  11. version bump

    alonp99 committed Sep 2, 2024
    Copy the full SHA
    34dbdfa View commit details
  12. version bump

    alonp99 committed Sep 2, 2024
    Copy the full SHA
    dc4e7b4 View commit details

Commits on Sep 3, 2024

  1. Fix merchant screening block empty state (#2670)

    * fix(backoffice-v2): now rendering an empty state for merchant screening block
    
    * fix(backoffice-v2): fixed bad isObject check
    Omri-Levy authored Sep 3, 2024
    Copy the full SHA
    07340ed View commit details
  2. Copy the full SHA
    ac74924 View commit details

Commits on Sep 4, 2024

  1. feat: fixed db reset script

    Blokh committed Sep 4, 2024
    Copy the full SHA
    ee62d2c View commit details
  2. Chatbot (#2679)

    * feat(bot): chat bot
    
    * feat(bot): chat bot
    alonp99 authored Sep 4, 2024
    Copy the full SHA
    0037633 View commit details
  3. Chatbot2 (#2680)

    * feat(bot): chat bot
    
    * feat(bot): chat bot
    
    * feat(bot): chat bot
    
    * feat(bot): chat bot
    alonp99 authored Sep 4, 2024
    Copy the full SHA
    1c35980 View commit details
  4. feature/business_report_metrics (#2658)

    * added status metric reports
    
    * added mcc stats
    
    * feat: added aggregations and handling of pie charts
    
    * feat: finalized metrics of reports
    
    * fixed comments
    
    * feat: fixed comments of Omri
    
    ---------
    
    Co-authored-by: Omri Levy <61207713+Omri-Levy@users.noreply.github.com>
    Blokh and Omri-Levy authored Sep 4, 2024
    Copy the full SHA
    64b30cc View commit details
  5. Revert "feature/business_report_metrics (#2658)"

    This reverts commit 64b30cc.
    alonp99 committed Sep 4, 2024
    Copy the full SHA
    88aedcd View commit details
  6. Copy the full SHA
    198b646 View commit details
  7. Copy the full SHA
    7409d7c View commit details
  8. KYC button hotfix (#2683)

    * fixed merchant screening rule
    
    * fixed merchant screening rule
    Omri-Levy authored Sep 4, 2024
    Copy the full SHA
    be4d302 View commit details

Commits on Sep 5, 2024

  1. Chatbot css fix (#2686)

    * fix(backoffice-v2): moved chatbot to iframe
    
    * revert(backoffice-v2): reverted config default
    
    * feat(backoffice-v2): made a portal component
    Omri-Levy authored Sep 5, 2024
    Copy the full SHA
    18f6d46 View commit details
  2. Copy the full SHA
    a06e7c0 View commit details
  3. Fixing reports issues (#2689)

    * feat: fixing reports issues
    
    * fix(*): now passing maxBusinessReports instead of config
    
    * fix(h): fixed optional chaining
    
    ---------
    
    Co-authored-by: Omri Levy <omri.levy0197@gmail.com>
    tomer-shvadron and Omri-Levy authored Sep 5, 2024
    Copy the full SHA
    5506a77 View commit details

Commits on Sep 8, 2024

  1. Copy the full SHA
    fe7200a View commit details
  2. Added loader to batch report upload (#2691)

    * feat: added loader to Batch report Upload
    
    * feat: pr comments fixes
    tomer-shvadron authored Sep 8, 2024
    Copy the full SHA
    f715f2f View commit details

Commits on Sep 9, 2024

  1. Copy the full SHA
    afd9ddc View commit details
  2. Copy the full SHA
    f40549e View commit details
  3. fix: changed file name with test prefix (#2673)

    * fix: resolve json parse error and changed file name with test prefix
    
    * fix: removing the repo dispatch from testing action
    
    ---------
    
    Co-authored-by: Chirag Sharma IAMOPS <chirag.sharma@billrun.com>
    Co-authored-by: Mayur Duduka <100664505+MayurDuduka@users.noreply.github.com>
    3 people authored Sep 9, 2024
    Copy the full SHA
    7ad93fd View commit details

Commits on Sep 10, 2024

  1. feat: fenced upload multiple merchants behind feature flag (#2694)

    Co-authored-by: Alon Peretz <8467965+alonp99@users.noreply.github.com>
    tomer-shvadron and alonp99 authored Sep 10, 2024
    Copy the full SHA
    eebaba4 View commit details
  2. Dev 318/workflow on demand migration (#2693)

    * feature: added an action to run db-migration jobs on demand
    
    * ci: new CI/CD containing on-demand db migration and wf-service deployment de-coupled
    
    * chore: adding the old job in the branch
    
    * feature: added an action to run db-migration jobs on demand
    
    * ci: new CI/CD containing on-demand db migration and wf-service deployment de-coupled
    
    * chore: adding the old job in the branch
    
    * chore:making relevant changes in old ci cd
    
    * chore: removed on push triggers from the workflows
    
    * fix: adding recommended changes from code rabbit
    
    * chore: changing file name for the build and push image action
    
    * fix: changing the helm chart temporarily for testing
    
    * fix: temporarily removing if migration needed dependency for ee image
    
    * fix: temporarily changing sparse checkout
    
    * fix: temporarily changing determine branch to dev in workflow dispatch
    
    * fix: temporary change for wf-service determine branch job
    
    * fix: changing way of taking inputs
    
    * fix: fixing error for json parser
    
    * fix: json parser error in yaml update
    
    * fix: json parse issue on deploy job
    
    * fix: input name on deploy job
    
    * feat: adding new action for manual ArgoCD Sync
    
    * feat: adding additional step for sending slack messages on successful deployments
    
    * fix: resolving json parse error
    
    * fix: removing manual argo-cd sync step
    
    * fix: adding test files with test prefix with new triggers like on push and repo dispatch
    
    * fix: adding push event in deploy to dev
    
    * fix: adding custom event for repo dispatch
    
    * fix: changing the conditions for deployment jobs trigger
    
    * fix(ci-cd): adding dev application ready changes in the wf-service test actions
    
    * feat(ci-cd): adding tags for all the environments in docker tag
    
    ---------
    
    Co-authored-by: Chirag Sharma IAMOPS <chirag@iamops.io>
    codechirag123 and codechirag123 authored Sep 10, 2024
    Copy the full SHA
    94b226f View commit details
  3. fix: circular dependency (#2696)

    Co-authored-by: Lior Zamir <liorz@ballerine.com>
    liorzam and liorzblrn authored Sep 10, 2024
    Copy the full SHA
    829c50a View commit details

Commits on Sep 11, 2024

  1. Copy the full SHA
    40ec890 View commit details
  2. Dev 318/workflow on demand migration (#2697)

    * feature: added an action to run db-migration jobs on demand
    
    * ci: new CI/CD containing on-demand db migration and wf-service deployment de-coupled
    
    * chore: adding the old job in the branch
    
    * feature: added an action to run db-migration jobs on demand
    
    * ci: new CI/CD containing on-demand db migration and wf-service deployment de-coupled
    
    * chore: adding the old job in the branch
    
    * chore:making relevant changes in old ci cd
    
    * chore: removed on push triggers from the workflows
    
    * fix: adding recommended changes from code rabbit
    
    * chore: changing file name for the build and push image action
    
    * fix: changing the helm chart temporarily for testing
    
    * fix: temporarily removing if migration needed dependency for ee image
    
    * fix: temporarily changing sparse checkout
    
    * fix: temporarily changing determine branch to dev in workflow dispatch
    
    * fix: temporary change for wf-service determine branch job
    
    * fix: changing way of taking inputs
    
    * fix: fixing error for json parser
    
    * fix: json parser error in yaml update
    
    * fix: json parse issue on deploy job
    
    * fix: input name on deploy job
    
    * feat: adding new action for manual ArgoCD Sync
    
    * feat: adding additional step for sending slack messages on successful deployments
    
    * fix: resolving json parse error
    
    * fix: removing manual argo-cd sync step
    
    * fix: adding test files with test prefix with new triggers like on push and repo dispatch
    
    * fix: adding push event in deploy to dev
    
    * fix: adding custom event for repo dispatch
    
    * fix: changing the conditions for deployment jobs trigger
    
    * fix(ci-cd): adding dev application ready changes in the wf-service test actions
    
    * feat(ci-cd): adding tags for all the environments in docker tag
    
    * fix: adding actual service in the workflows-service ci-cd
    
    ---------
    
    Co-authored-by: Chirag Sharma IAMOPS <chirag.sharma@billrun.com>
    codechirag123 and Chirag Sharma IAMOPS authored Sep 11, 2024
    Copy the full SHA
    a184915 View commit details

Commits on Sep 12, 2024

  1. feat: upgrade packages (#2704)

    Blokh authored Sep 12, 2024
    Copy the full SHA
    e8fa9fd View commit details
  2. feat(cli): init (#2688)

    * feat(cli): init
    
    * chore(mm): some csv and run websites improvements
    
    * public standard kyb
    
    ---------
    
    Co-authored-by: Alon Peretz <8467965+alonp99@users.noreply.github.com>
    Omri-Levy and alonp99 authored Sep 12, 2024
    Copy the full SHA
    41f5644 View commit details
  3. Revert "Chatbot css fix (#2686)"

    This reverts commit 18f6d46.
    alonp99 committed Sep 12, 2024
    Copy the full SHA
    6f34bde View commit details
  4. Revert "Revert "Chatbot css fix (#2686)""

    This reverts commit 6f34bde.
    alonp99 committed Sep 12, 2024
    Copy the full SHA
    10f6336 View commit details

Commits on Sep 15, 2024

  1. Ecosystem and Transactions tab update (#2698)

    * feat: removed transactions from ecosystem
    
    * feat: added transactions tab
    
    * feat: added css for premium feature block
    
    * feat: updating packages
    
    * feat: pR comments fixes
    
    * feat: version bump
    tomer-shvadron authored Sep 15, 2024
    Copy the full SHA
    4d7488c View commit details
  2. Copy the full SHA
    e395928 View commit details
  3. Blocks data sorting (#2709)

    * feat: blocks data sorting
    
    * feat: pR comments fix
    tomer-shvadron authored Sep 15, 2024
    Copy the full SHA
    2226e58 View commit details

Commits on Sep 16, 2024

  1. Merchant monitoring pages fixes (#2711)

    * feat: merchant monitoring pages fixes
    
    * feat: bal-2690
    
    * feat: added small fix
    
    * feat: removed unnecessary const
    tomer-shvadron authored Sep 16, 2024
    Copy the full SHA
    cfe61ef View commit details
  2. feat: add new rules (#2707)

    liorzam authored Sep 16, 2024
    Copy the full SHA
    ceb211d View commit details

Commits on Sep 17, 2024

  1. Copy the full SHA
    c39a8df View commit details

Commits on Sep 18, 2024

  1. chore(versions): bump

    alonp99 committed Sep 18, 2024
    Copy the full SHA
    26d22ad View commit details
  2. feat: implemented redirects handling (#2715)

    * feat: implemented redirects handling
    
    * fix: removed debugger & added loading screen to failed
    chesterkmr authored Sep 18, 2024
    Copy the full SHA
    d763a65 View commit details
  3. Copy the full SHA
    c697b2e View commit details
  4. bal 2704 (#2719)

    * feat: bal-2704
    
    * feat: small change
    
    ---------
    
    Co-authored-by: Alon Peretz <8467965+alonp99@users.noreply.github.com>
    tomer-shvadron and alonp99 authored Sep 18, 2024
    Copy the full SHA
    c13e7be View commit details
  5. Workflow endpoints models (#2716)

    * chore(wf): workflows endpoint models update
    
    * chore(versions): bump
    
    * chore(versions): bump
    
    * chore(versions): bump
    alonp99 authored Sep 18, 2024
    Copy the full SHA
    7b97b88 View commit details
Showing 1,873 changed files with 121,788 additions and 35,855 deletions.
2 changes: 1 addition & 1 deletion .changeset/config.json
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
"changelog": "@changesets/changelog-git",
"commit": false,
"fixed": [],
"linked": [],
"linked": [["@ballerine/ui", "@ballerine/backoffice-v2"]],
"access": "public",
"baseBranch": "dev",
"updateInternalDependencies": "patch",
146 changes: 146 additions & 0 deletions .cursor/rules/backoffice-v2.mdc
Original file line number Diff line number Diff line change
@@ -0,0 +1,146 @@
---
description: Rules and best practices for backoffice-v2 React TypeScript development
globs: ["apps/backoffice-v2/**/*.{ts,tsx}"]
---

# Backoffice V2 Development Rules

## Component Architecture
- Use functional components with TypeScript
- Implement smart/dumb component pattern
- Place components in feature-based directories
- Use compound components for complex UIs
- Follow atomic design principles

```typescript
export const MyComponent: FunctionComponent<Props> = () => {
return <div>...</div>;
};

// Compound component example
MyComponent.SubComponent = ({ children }) => {
return <div>{children}</div>;
};
```

## Hooks and Logic
- Separate business logic into custom hooks
- Place hooks in dedicated `hooks` directories
- Use the `use` prefix for all hooks
- Implement hook composition pattern
- Keep hooks focused and reusable

```typescript
// Logic hook example
export const useComponentLogic = () => {
// Business logic
return {
// Hook return values
};
};
```

## State Management
- Use React Query for server state
- Use Context for shared state
- Implement state machines for complex flows
- Use local state for UI-only state
- Follow unidirectional data flow

## TypeScript Best Practices
- Use strict TypeScript configuration
- Define interfaces for all props
- Use discriminated unions for state
- Leverage type inference
- Export types from separate files

## UI Components
- Use Radix UI for accessible components
- Implement proper ARIA attributes
- Follow consistent styling patterns
- Use composition over inheritance
- Keep components small and focused

## Forms and Validation
- Use React Hook Form for forms
- Implement Zod for validation
- Handle form submission states
- Show validation feedback
- Use controlled inputs when needed

## Data Fetching
- Use React Query for API calls
- Implement proper loading states
- Handle error states gracefully
- Cache responses appropriately
- Type API responses

## Error Handling
- Use error boundaries
- Implement fallback UI
- Handle async errors
- Show user-friendly messages
- Log errors appropriately

## Performance
- Use React.memo wisely
- Implement proper code splitting
- Use lazy loading for routes
- Optimize re-renders
- Profile performance regularly

## Testing
- Write unit tests for components
- Test custom hooks independently
- Use React Testing Library
- Mock external dependencies
- Maintain good coverage

## File Structure
- Follow feature-based organization
- Use index files for exports
- Keep related files together
- Use consistent naming
- Implement barrel exports

## Styling
- Use Tailwind CSS
- Follow utility-first approach
- Use CSS variables for theming
- Keep styles maintainable
- Use CSS modules when needed

## Documentation
- Document complex logic
- Write clear component docs
- Document hook usage
- Keep docs up to date
- Use JSDoc when helpful

## Code Quality
- Follow ESLint rules
- Use consistent formatting
- Write clear variable names
- Keep functions pure
- Use meaningful types

## Security
- Validate user input
- Implement proper authentication
- Handle sensitive data carefully
- Follow security best practices
- Use HTTPS for API calls

## Accessibility
- Follow WCAG guidelines
- Use semantic HTML
- Test with screen readers
- Ensure keyboard navigation
- Provide proper focus management

## Best Practices
- Follow React patterns
- Keep code DRY
- Handle edge cases
- Write maintainable code
- Review code regularly
11 changes: 11 additions & 0 deletions .cursor/rules/comments.mdc
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
description: How to write comments
globs:
---
Write comments thoughtfully:
- Do NOT write comments that explain obvious code or restate WHAT the code does.
- Comments should primarily explain WHY code exists or WHY a particular approach was chosen.
- Only add comments for complex, non-intuitive logic where the code itself doesn't clearly communicate intent.
- Always provide clear documentation for functions (purpose, inputs, outputs).
- Avoid unnecessary comments that add visual noise without adding value.
- Write comments only when they provide genuine insight or when explicitly requested.
115 changes: 115 additions & 0 deletions .cursor/rules/kyb-app.mdc
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
---
description: Rules and best practices for kyb-app React TypeScript development
globs: ["apps/kyb-app/**/*.{ts,tsx}"]
---

# KYB App Development Rules

## Component Structure
- Use functional components with TypeScript
- Export components as named exports
- Place components in feature-based directories
- Use `FunctionComponent` type for React components

```typescript
export const MyComponent: FunctionComponent<Props> = () => {
return <div>...</div>;
};
```

## Hooks
- Place hooks in a `hooks` directory within the feature directory
- Export hooks as named exports
- Use the `use` prefix for all hooks
- Prefer custom hooks for reusable logic
- Keep hooks focused and single-purpose

```typescript
export const useMyHook = () => {
// Hook logic
};
```

## State Management
- Use React Query for server state
- Use React Context for global UI state
- Use local state for component-specific state
- Prefer `useState` for simple state
- Use `useReducer` for complex state logic

## TypeScript
- Use strict TypeScript configuration
- Define interfaces for all props
- Use type inference where possible
- Export types and interfaces from separate files
- Use discriminated unions for complex state

## Styling
- Use Tailwind CSS for styling
- Follow utility-first approach
- Use `ctw` utility for conditional classes
- Keep styles close to components
- Use CSS modules for complex styling needs

## File Organization
- Group related files in feature directories
- Use index files for clean exports
- Keep files focused and single-purpose
- Follow consistent naming conventions
- Use barrel exports for cleaner imports

## Error Handling
- Use error boundaries for component errors
- Implement proper error states
- Handle async errors gracefully
- Show user-friendly error messages
- Log errors appropriately

## Performance
- Use React.memo for expensive renders
- Implement proper dependency arrays in hooks
- Avoid unnecessary re-renders
- Use lazy loading for routes
- Implement proper code splitting

## Testing
- Write unit tests for components
- Test custom hooks independently
- Use React Testing Library
- Follow testing best practices
- Maintain good test coverage

## Forms
- Use React Hook Form for form handling
- Implement proper form validation
- Handle form submission states
- Show validation feedback
- Use controlled components when needed

## API Integration
- Use React Query for data fetching
- Implement proper loading states
- Handle error states gracefully
- Cache responses appropriately
- Use TypeScript for API types

## Accessibility
- Follow WCAG guidelines
- Use semantic HTML
- Implement proper ARIA attributes
- Ensure keyboard navigation
- Test with screen readers

## Code Quality
- Use ESLint for code quality
- Follow consistent code style
- Write clear documentation
- Use meaningful variable names
- Keep functions pure when possible

## Best Practices
- Follow React best practices
- Keep components small and focused
- Use proper prop types
- Implement proper loading states
- Handle edge cases appropriately
Loading