fix: Python publishing fails on some Python distributions #4776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our recent `jsii-pacmak` release contained an update to `twine` which exhibits a failure when combined with specific versions of `packaging`. When reading the [bug thread](pypa/twine#1216) the root cause seems to be `setuptools`, but the workaround seems to depend on the installed version of `packaging`. `twine` declares a dependency on `packaging>=24.0.0` and the bug doesn't appear if `24.2` is installed. As a result, the problem shows on Python distributions that come with `[email protected]` or `[email protected]` preinstalled. If an older version or no version of `packaging` is preinstalled then `pip` will install a fresh copy and it will pick `24.2`, but older versions match the declared version range and the pre-existing version will be used, which leads to the problem. To solve, add the required minimum version of `packaging` to our own dependency file.
mrgrain
approved these changes
Feb 24, 2025
iliapolo
reviewed
Feb 24, 2025
|
|
||
| # The dependency on packaging is necessary to work around an incompatibility between | ||
| # what setuptools generates and what twine expects. <https://github.com/pypa/twine/issues/1216> | ||
| packaging >= 24.2 |
There was a problem hiding this comment.
nit (maybe): pip is cool with spaces?
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our recent
jsii-pacmakrelease contained an update totwinewhich exhibits a failure when combined with specific versions ofpackaging.When reading the bug thread the root cause seems to be
setuptools, but the workaround seems to depend on the installed version ofpackaging.twinedeclares a dependency onpackaging>=24.0.0and the bug doesn't appear if24.2is installed. As a result, the problem shows on Python distributions that come with[email protected]or[email protected]preinstalled.If an older version or no version of
packagingis preinstalled thenpipwill install a fresh copy and it will pick24.2, but older versions match the declared version range and the pre-existing version will be used, which leads to the problem.To solve, add the required minimum version of
packagingto our own dependency file.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.