fix(jsii): handle imports from libraries compiled with old jsii #3245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix introduced in #3233 relied on the jsii libraries being recompiled with symbolid information. This information was introduced in jsii 1.39.0. With the code from #3233, symbols from libraries compiled with older jsii versions could not be located and the compilation would fail. In this PR, restore the compatibility by falling back to the same FQN that the original code would have guessed. It will not be correct if the type comes from a submodule, but only CDK is using submodules and CDK is using a new jsii compiler.
njlynch
approved these changes
Dec 10, 2021
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix introduced in #3233 relied on the jsii libraries being recompiled with
symbolid information. This information was introduced in jsii 1.39.0.
With the code from #3233, symbols from libraries compiled with older jsii
versions could not be located and the compilation would fail.
In this PR, restore the compatibility by falling back to the same FQN
that the original code would have guessed. It will not be correct
if the type comes from a submodule, but only CDK is using submodules
and CDK is using a new jsii compiler.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.