fix: C# NamespaceDoc emitted to wrong location #3183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The namespace determination for the `NamespaceDoc` class generated for submodules was incorrect, as the `jsiiNs` passed to the type resovler was absolute, instead of being the required assembly-relative form. Additionally, removed the `readme` and `locationInSource` property from submodule descriptors included in the jsii assembly under `dependencyClosure`, as those are not necessary and needlessly bloat the assembly document.
rix0rrr
requested changes
Nov 18, 2021
rix0rrr
approved these changes
Nov 18, 2021
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The namespace determination for the
NamespaceDocclass generated forsubmodules was incorrect, as the
jsiiNspassed to the type resovlerwas absolute, instead of being the required assembly-relative form.
Additionally, removed the
readmeandlocationInSourceproperty fromsubmodule descriptors included in the jsii assembly under
dependencyClosure, as those are not necessary and needlessly bloat theassembly document.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.