-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rosetta): Rosetta is not submodule-aware #3176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synthetically generated examples used to look like this: ```py from aws_cdk import aws_ec2 as ec2 construct = new ec2.MyConstruct('some', 'values', arg=DeeperStruct(...) ) ``` Notice that `DeeperStruct` is missing the module prefix that would allow this code to work. Trace what imports we've already done (to see if we can piggyback onto any existing imports), otherwise generate new imports for the namespaces we need to reference struct names from.
NOTE: not complete yet for submodules. Requires #3174 to finish. |
RomainMuller
approved these changes
Nov 18, 2021
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Merging (with squash)... |
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rosetta was not properly aware of submodules and namespaces, at all. This manifested in two different ways:
The translation of a call involving a struct:
Used to be translated into this:
Notice that
DeeperStruct
is missing the module prefix that wouldallow this code to work.
We trace what jsii FQNs every imported symbol refers to, and see
if we can reuse an import that already exists to retrieve our struct.
If not, we'll generate a new import at the top of the example.
To properly track what is being imported in an example (if it's a class or
a module, or potentially a submodule) we needed to be able to identify
submodules in TypeScript source, so we've also attached a
symbolId
to
submodules
in the jsii assembly.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.